Ensure that hostnames without dots are excluded. #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes StevenBlack#2347.
|
Thanks Nissar! @funilrys This one has been bothering us for awhile. Merging! |
|
Unfortunately Nissar @funilrys this change removes or truncates all domains containing dashes. For example, truncations: 
The truncation causes a great number of duplicates (deduplication is subsequent) so, in the end, some 40k domains disappear from the base list. So I'm going to revert this change. |
StevenBlack
added a commit
that referenced
this pull request
Jul 27, 2023
|
However Nissar @funilrys I'm keeping the new test you added 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #2347.